Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a procedure for repairing limbs via surgery. #5386

Merged
merged 1 commit into from Jul 14, 2018

Conversation

Mechoid
Copy link
Contributor

@Mechoid Mechoid commented Jul 2, 2018

Tweaks:

  • Toolspeed on tape has been adjusted for use as surgical tools. If.. you're insane. Slightly better for Brute damage.
  • Autopsy scanner can now be used as a proper surgical tool.
  • Surgical cyborgs and Combat Medic cyborgs now have autopsy scanners.

Features:

  • Surgical repair of brute and burn on living patients.
  • If you do not have access to an advanced scanner, the autopsy scanner will inform you upon completion of the step what damage types are present, and if the limb is fractured.
    Steps:
    Scalpel, Hemostat, Retractor [Standard Opening] - > Autopsy Scanner - > Trauma kit or Adv Burn Kit, depending on damage type(s) present.

@Mechoid Mechoid added Feature The PR adds new functionality in some way. Feature Tweak The PR changes an existing feature in a small way. labels Jul 2, 2018
@Mechoid Mechoid force-pushed the End_The_Tyranny_Of_Chemistry branch from 367293c to 4314080 Compare July 2, 2018 08:53
@Wickedtemp
Copy link
Contributor

I love it.

@@ -167,21 +167,24 @@
if(!istype(M))
return 0

if (user.a_intent == I_HELP)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"If they ARE on help intent, call the parent proc instead" == "If they AREN'T on help intent, actually perform the specific surgery applications of this tool

Afaik surgery is typically done explicitly on help intent, so is this intentional?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surgery is done on help intent, yes.

Copy link
Contributor Author

@Mechoid Mechoid Jul 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are not on help, you will do the normal 'person is dead, do forensics scan'. Otherwise, it will attempt the living surgery for scanning internal damage. Help is required because the parent checks for help.

@Anewbe Anewbe added the Input: Staff [PR] The author is needed to respond to a review or message. label Jul 6, 2018
@Wickedtemp
Copy link
Contributor

Wickedtemp commented Jul 7, 2018

https://forum.ss13polaris.com/viewtopic.php?f=14&t=364

We had a forum post about it back in Novmlember, but the discussion died.

@InvisPinkUnicorn
Copy link

InvisPinkUnicorn commented Jul 8, 2018

Is it possible to use this surgery to lower Brute/Burn damage on corpses with this surgery? If so, could this be used to defib someone from an arbitrary amount of Brute/Burn damage? I'm concerned that this will be added, exploited for True Resurrection(tm), and then promptly removed or gutted in response.

@Anewbe Anewbe removed the Input: Staff [PR] The author is needed to respond to a review or message. label Jul 8, 2018
@Mechoid
Copy link
Contributor Author

Mechoid commented Jul 8, 2018

There is a specific check if they are alive in the base step's can_use to prevent using this for defibbing.

@InvisPinkUnicorn
Copy link

Nice! Good to hear.

/datum/surgery_step/repairflesh/scan_injury
allowed_tools = list(
/obj/item/weapon/autopsy_scanner = 100,
/obj/item/device/healthanalyzer = 50,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump this up to 80, please. Not everyone who's gonna want to do this surgery (ie. antags) is going to have an autopsy scanner at hand.

@Mechoid Mechoid force-pushed the End_The_Tyranny_Of_Chemistry branch from 4314080 to 4b78966 Compare July 11, 2018 06:48
@Anewbe
Copy link
Contributor

Anewbe commented Jul 12, 2018

This seems good to merge, but it absolutely must be put on the wiki once it's implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Tweak The PR changes an existing feature in a small way. Feature The PR adds new functionality in some way.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants